Issue 23545009: Land a test change that should have been part of r1704.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23545009: Land a test change that should have been part of r1704. (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
Mark Mentovai, mark

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Land a test change that should have been part of r1704. 1704 was reviewed at https://codereview.chromium.org/23461010/ TBR=mark Committed: https://code.google.com/p/gyp/source/detail?r=1705

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	test/mac/framework/framework.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

Committed patchset #1 manually as r1705 (presubmit successful).

7 years, 3 months ago (2013-08-27 23:35:39 UTC) #1

Message was sent while issue was closed.

I think you mean mark@chromium.org. LGTM.