ninja/mac: Don't write .TOC files into framework bundles.

ninja/mac: Don't write .TOC files into framework bundles.

Target.UsesToc() already returns False for framework bundles, so don't run
a linker command that writes a .TOC file next to the binary for bundles.
Since TOCs are already not used for frameworks, this won't change build
performance.

This way, ninja-built Chromium Framework.framework will be a bit smaller.
(Other ninja-built frameworks will become smaller too, for example
Light Table.app currently ships with 300kB of useless .TOC / .tmp junk in
their node-webkit Framework.framework, which will go away once they pick up
this patch.)

R=mark@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1704

[Mark Mentovai, 2013-08-27 21:40:45]

LGTM

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py
File test/mac/gyptest-framework.py (right):

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py...
test/mac/gyptest-framework.py:69: 'Test Framework',
There are no symlinks in here?

[Nico, 2013-08-27 21:42:35]

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py
File test/mac/gyptest-framework.py (right):

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py...
test/mac/gyptest-framework.py:69: 'Test Framework',
On 2013/08/27 21:40:45, Mark Mentovai wrote:
> There are no symlinks in here?

"Test Framework" is a symlink to the binary (pointing to "Versions/A/Test
Framework"). Versions/Current and Resources are symlinks pointing to
directories, but ls() returns only files not directories, and doesn't traverse
directory symlinks.

[Mark Mentovai, 2013-08-27 21:44:34]

LGTM still

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py
File test/mac/gyptest-framework.py (right):

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py...
test/mac/gyptest-framework.py:69: 'Test Framework',
On 2013/08/27 21:42:35, Nico wrote:
> On 2013/08/27 21:40:45, Mark Mentovai wrote:
> > There are no symlinks in here?
> 
> "Test Framework" is a symlink to the binary (pointing to "Versions/A/Test
> Framework"). Versions/Current and Resources are symlinks pointing to
> directories, but ls() returns only files not directories, and doesn't traverse
> directory symlinks.

Hmph. I was expecting to see Versions/Current and Resources, but if that’s how
os.walk is gonna be…

[Mark Mentovai, 2013-08-27 21:45:45]

Looks like the test (on Xcode) caught something good. Go tests!

[Nico, 2013-08-27 21:45:56]

Thanks, landing

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py
File test/mac/gyptest-framework.py (right):

https://codereview.chromium.org/23461010/diff/1/test/mac/gyptest-framework.py...
test/mac/gyptest-framework.py:69: 'Test Framework',
On 2013/08/27 21:44:35, Mark Mentovai wrote:
> On 2013/08/27 21:42:35, Nico wrote:
> > On 2013/08/27 21:40:45, Mark Mentovai wrote:
> > > There are no symlinks in here?
> > 
> > "Test Framework" is a symlink to the binary (pointing to "Versions/A/Test
> > Framework"). Versions/Current and Resources are symlinks pointing to
> > directories, but ls() returns only files not directories, and doesn't
traverse
> > directory symlinks.
> 
> Hmph. I was expecting to see Versions/Current and Resources, but if that’s how
> os.walk is gonna be…

The existence of the symlinks is checked explicitly below "# Symlinks created by
packaging process" a few lines up. This check here is more to check that nothing
else is in the bundle.

[Nico, 2013-08-27 21:46:37]

Committed patchset #1 manually as r1704 (presubmit successful).

[Mark Mentovai, 2013-08-27 21:47:46]

Oops. Gotta back it out.

It looks like Xcode is right here, and ninja/make need to learn about
mac_framework_headers.

[Mark Mentovai, 2013-08-27 21:51:02]

That’s fine. Our messages were crossing in the mail.