Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2354493002: Don't treat shorthand filters as errors on SVG content (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Don't treat shorthand filters as errors on SVG content We don't support filter shorthands yet, so we shouldn't treat them as errors. Fix up the hasFilter() condition to also check if it's a filter that we pretend we can handle. Also straighten out the code-flow in applyFilterIfNecessary. BUG=645995 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2349743003 Cr-Commit-Position: refs/heads/master@{#419267} (cherry picked from commit 05c8461dff1ce44b6bb1d2675492078d332bd209) Committed: https://chromium.googlesource.com/chromium/src/+/fef0448cb827d93c413fce345d37cf02ca9e9702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 chunk +28 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
4 years, 3 months ago (2016-09-19 08:02:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fef0448cb827d93c413fce345d37cf02ca9e9702.

Powered by Google App Engine
This is Rietveld 408576698