Don't treat shorthand filters as errors on SVG content

Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=645995
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209
Cr-Commit-Position: refs/heads/master@{#419267}

[fs, 2016-09-16 15:59:43]

Description was changed from

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

BUG=647611
==========

to

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-16 15:59:50]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-16 16:54:30]

Description was changed from

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNeeded.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-16 16:54:55]

Description was changed from

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNeeded.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-16 16:58:48]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:59:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:16:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:16:56]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-16 18:33:30]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2016-09-16 18:39:23]

Description was changed from

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=647611
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=645995
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-16 18:45:17]

https://codereview.chromium.org/2349743003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html
(right):

https://codereview.chromium.org/2349743003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html:69:
<rect fill="lime" x="0" y="0" height="50" width="50"
Do we match firefox in this case?

[fs, 2016-09-16 19:02:34]

https://codereview.chromium.org/2349743003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html
(right):

https://codereview.chromium.org/2349743003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html:69:
<rect fill="lime" x="0" y="0" height="50" width="50"
On 2016/09/16 at 18:45:17, pdr. wrote:
> Do we match firefox in this case?

Well, they support shorthand filters on SVG, so it's kind of hard to give a
definitive answer here... I guess it's more a matter of whether we want this to
be lime or red. I've gone with codifying our current behavior here (which I
think was the intention of this test.)

[pdr., 2016-09-16 19:07:18]

lgtm

[fs, 2016-09-16 20:09:52]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-16 20:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:16:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 20:19:03]

Description was changed from

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=645995
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't treat shorthand filters as errors on SVG content

We don't support filter shorthands yet, so we shouldn't treat them as
errors. Fix up the hasFilter() condition to also check if it's a filter
that we pretend we can handle.

Also straighten out the code-flow in applyFilterIfNecessary.

BUG=645995
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209
Cr-Commit-Position: refs/heads/master@{#419267}
==========

[commit-bot: I haz the power, 2016-09-16 20:19:04]

Patchset 2 (id:??) landed as
https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209
Cr-Commit-Position: refs/heads/master@{#419267}