Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2354433003: Fix incorrect comment for AddToHomeScreenManager::Observer::onReadyToAdd. (Closed)

Created:
4 years, 3 months ago by F
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect comment for AddToHomeScreenManager::Observer::onReadyToAdd. BUG=NONE Committed: https://crrev.com/3f2b4ff8d1ac8930dfa0f36559859eb8724a7210 Cr-Commit-Position: refs/heads/master@{#419527}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Dan's suggestion #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 15 (7 generated)
F
dfalcantara, Can you please take a look? Thanks.
4 years, 3 months ago (2016-09-19 18:12:03 UTC) #2
gone
https://codereview.chromium.org/2354433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java (right): https://codereview.chromium.org/2354433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java#newcode26 chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java:26: * Manifest) and is ready for {@link AddToHomescreenManager#addShortcut()} to ...
4 years, 3 months ago (2016-09-19 18:16:34 UTC) #3
F
Dan, PTAL thanks!
4 years, 3 months ago (2016-09-19 18:32:42 UTC) #4
gone
lgtm https://codereview.chromium.org/2354433003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java (right): https://codereview.chromium.org/2354433003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java#newcode26 chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java:26: * Manifest) and is ready for {@link AddToHomescreenManager#addShortcut} ...
4 years, 3 months ago (2016-09-19 18:34:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354433003/20001
4 years, 3 months ago (2016-09-19 18:43:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354433003/20001
4 years, 3 months ago (2016-09-19 19:15:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 19:21:37 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:02:59 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f2b4ff8d1ac8930dfa0f36559859eb8724a7210
Cr-Commit-Position: refs/heads/master@{#419527}

Powered by Google App Engine
This is Rietveld 408576698