Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

Issue 2354433003: Fix incorrect comment for AddToHomeScreenManager::Observer::onReadyToAdd. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.webapps; 5 package org.chromium.chrome.browser.webapps;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.graphics.Bitmap; 8 import android.graphics.Bitmap;
9 9
10 import org.chromium.base.annotations.CalledByNative; 10 import org.chromium.base.annotations.CalledByNative;
11 import org.chromium.chrome.browser.tab.Tab; 11 import org.chromium.chrome.browser.tab.Tab;
12 import org.chromium.content_public.browser.WebContents; 12 import org.chromium.content_public.browser.WebContents;
13 13
14 /** 14 /**
15 * Manages the add-to-homescreen process. 15 * Manages the add-to-homescreen process.
16 */ 16 */
17 public class AddToHomescreenManager { 17 public class AddToHomescreenManager {
18 18
19 /** Interface for tracking fetch of add-to-homescreen data. */ 19 /** Interface for tracking fetch of add-to-homescreen data. */
20 public interface Observer { 20 public interface Observer {
21 /** Called when the title of the page is available. */ 21 /** Called when the title of the page is available. */
22 void onUserTitleAvailable(String title); 22 void onUserTitleAvailable(String title);
23 23
24 /** 24 /**
25 * Called once native has finished fetching the homescreen shortcut's da ta (like the Web 25 * Called once native has finished fetching the homescreen shortcut's da ta (like the Web
26 * Manifest) and is ready for {@link AddToHomescreenDelegate#addShortcut ()} to be called. 26 * Manifest) and is ready for {@link AddToHomescreenManager#addShortcut( )} to be called.
gone 2016/09/19 18:16:34 Still not quite right; Eclipse will probably still
27 * @param icon Icon to use in the launcher. 27 * @param icon Icon to use in the launcher.
28 */ 28 */
29 void onReadyToAdd(Bitmap icon); 29 void onReadyToAdd(Bitmap icon);
30 } 30 }
31 31
32 private final Activity mActivity; 32 private final Activity mActivity;
33 private final Tab mTab; 33 private final Tab mTab;
34 34
35 private Observer mObserver; 35 private Observer mObserver;
36 private long mNativeAddToHomescreenManager; 36 private long mNativeAddToHomescreenManager;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 @CalledByNative 90 @CalledByNative
91 private void onReadyToAdd(Bitmap icon) { 91 private void onReadyToAdd(Bitmap icon) {
92 mObserver.onReadyToAdd(icon); 92 mObserver.onReadyToAdd(icon);
93 } 93 }
94 94
95 private native long nativeInitializeAndStart(WebContents webContents); 95 private native long nativeInitializeAndStart(WebContents webContents);
96 private native void nativeAddShortcut( 96 private native void nativeAddShortcut(
97 long nativeAddToHomescreenManager, String userRequestedTitle); 97 long nativeAddToHomescreenManager, String userRequestedTitle);
98 private native void nativeDestroy(long nativeAddToHomescreenManager); 98 private native void nativeDestroy(long nativeAddToHomescreenManager);
99 } 99 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698