document.close from bool to void

document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of skia's api. The C api is waiting on this change as well.

Required chrome CL: https://codereview.chromium.org/2355343003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002

Committed: https://skia.googlesource.com/skia/+/d14df7c700bf77c8c42c791ca7a865c1bbc96679

[reed1, 2016-09-21 20:52:03]

Description was changed from

==========
document.close from bool to void

BUG=skia:
==========

to

==========
document.close from bool to void

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

[reed1, 2016-09-21 21:01:20]

reed@google.com changed reviewers:
+ bungeman@google.com, halcanary@google.com

[reed1, 2016-09-21 21:01:21]

I posit we don't need the bool, and only in one place does chrome even look at
it. Thus we'd have to update that call-site first, and then we could land this.
wdyt?

[reed1, 2016-09-21 21:01:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:02:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-09-21 21:04:39]

On 2016/09/21 21:01:21, reed1 wrote:
> I posit we don't need the bool, and only in one place does chrome even look at
> it. Thus we'd have to update that call-site first, and then we could land
this.
> wdyt?

I have no objection.  No strong preference either way.

Also get src/xps/SkDocument_XPS.cpp

[commit-bot: I haz the power, 2016-09-21 21:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:15:07]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[reed1, 2016-09-22 13:59:25]

Description was changed from

==========
document.close from bool to void

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

to

==========
document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of
skia's api. The C api is waiting on this change as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

[reed1, 2016-09-22 13:59:32]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 13:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-22 14:04:54]

Description was changed from

==========
document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of
skia's api. The C api is waiting on this change as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

to

==========
document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of
skia's api. The C api is waiting on this change as well.

Required chrome CL: https://codereview.chromium.org/2355343003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

[commit-bot: I haz the power, 2016-09-22 14:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 14:07:00]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2016-09-22 14:22:22]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 14:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:14:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[reed1, 2016-09-22 16:53:24]

On 2016/09/21 21:04:39, Hal Canary wrote:
> On 2016/09/21 21:01:21, reed1 wrote:
> > I posit we don't need the bool, and only in one place does chrome even look
at
> > it. Thus we'd have to update that call-site first, and then we could land
> this.
> > wdyt?
> 
> I have no objection.  No strong preference either way.
> 
> Also get src/xps/SkDocument_XPS.cpp

Done

[reed1, 2016-09-22 17:25:40]

ping

[reed1, 2016-09-22 17:36:43]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 17:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:47:26]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-09-22 19:11:09]

On 2016/09/22 17:25:40, reed1 wrote:
> ping

Lgtm

[reed1, 2016-09-22 20:25:45]

Perhaps we can change it to void for now, but look-out in the future in case we
should return a real error value (at least for XPS) ?

[bungeman-skia, 2016-09-22 21:03:02]

lgtm

[reed1, 2016-09-22 21:11:24]

You two should get into the OWNERS file for chrome/printing

[reed1, 2016-09-22 21:11:29]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-09-22 21:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:12:48]

Description was changed from

==========
document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of
skia's api. The C api is waiting on this change as well.

Required chrome CL: https://codereview.chromium.org/2355343003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
==========

to

==========
document.close from bool to void

Nothing meaningful is returned, it is inconsistent with the bulk of the rest of
skia's api. The C api is waiting on this change as well.

Required chrome CL: https://codereview.chromium.org/2355343003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002

Committed:
https://skia.googlesource.com/skia/+/d14df7c700bf77c8c42c791ca7a865c1bbc96679
==========

[commit-bot: I haz the power, 2016-09-22 21:12:49]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d14df7c700bf77c8c42c791ca7a865c1bbc96679