Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: src/core/SkDocument.cpp

Issue 2354403002: document.close from bool to void (Closed)
Patch Set: keep endPortfolio returning a bool Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkDocument.h ('k') | src/pdf/SkPDFDocument.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkDocument.cpp
diff --git a/src/core/SkDocument.cpp b/src/core/SkDocument.cpp
index fa25e44f8645bb0c99d89015691bd42ce993d0f1..29db7f05e1fea68e30e1953511d79146af3a23a5 100644
--- a/src/core/SkDocument.cpp
+++ b/src/core/SkDocument.cpp
@@ -58,12 +58,12 @@ void SkDocument::endPage() {
}
}
-bool SkDocument::close() {
+void SkDocument::close() {
for (;;) {
switch (fState) {
case kBetweenPages_State: {
fState = kClosed_State;
- bool success = this->onClose(fStream);
+ this->onClose(fStream);
if (fDoneProc) {
fDoneProc(fStream, false);
@@ -71,13 +71,13 @@ bool SkDocument::close() {
// we don't own the stream, but we mark it nullptr since we can
// no longer write to it.
fStream = nullptr;
- return success;
+ return;
}
case kInPage_State:
this->endPage();
break;
case kClosed_State:
- return false;
+ return;
}
}
}
« no previous file with comments | « include/core/SkDocument.h ('k') | src/pdf/SkPDFDocument.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698