Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2354363002: Call StatisticsRecorder::Initialize in GlobalHistogramAllocator's ctor (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call StatisticsRecorder::Initialize in GlobalHistogramAllocator's ctor StatisticsRecorder is required to be initialized, especially for UMA_HISTOGRAM_SPARSE_SLOWLY which uses it on every call to get a histogram instance. R=bcwhite@chromium.org, asvitkine@chromium.org BUG=648494, crashpad:100

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : hack2 #

Patch Set 4 : hack3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M base/test/histogram_tester_unittest.cc View 1 2 3 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
scottmg
4 years, 3 months ago (2016-09-21 19:25:20 UTC) #1
bcwhite
lgtm https://codereview.chromium.org/2354363002/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2354363002/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode901 base/metrics/persistent_histogram_allocator.cc:901: StatisticsRecorder::Initialize(); Let's add a comment: Make sure the ...
4 years, 3 months ago (2016-09-21 19:35:11 UTC) #4
scottmg
https://codereview.chromium.org/2354363002/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2354363002/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode901 base/metrics/persistent_histogram_allocator.cc:901: StatisticsRecorder::Initialize(); On 2016/09/21 19:35:11, bcwhite wrote: > Let's add ...
4 years, 3 months ago (2016-09-21 19:37:57 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-21 19:39:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354363002/20001
4 years, 3 months ago (2016-09-21 19:50:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/73213)
4 years, 3 months ago (2016-09-21 20:13:27 UTC) #14
scottmg
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/73213/steps/base_unittests%20%28iPhone%205s%20iOS%209.0%29%20on%20Mac/logs/stdio Hmm, iOS only failure, super. Wild guess, iOS runs tests in-process so now there's ...
4 years, 3 months ago (2016-09-21 20:25:21 UTC) #15
scottmg
4 years, 3 months ago (2016-09-22 17:57:12 UTC) #17
On 2016/09/21 20:25:21, scottmg wrote:
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
> 
> Hmm, iOS only failure, super. Wild guess, iOS runs tests in-process so now
> there's a global interaction between tests?

Closing this in preference to Brian's amended version here that handles the
reinitialization during tests that ios-simulator was having trouble with:
https://codereview.chromium.org/2358023003/.

Powered by Google App Engine
This is Rietveld 408576698