Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: base/test/histogram_tester_unittest.cc

Issue 2354363002: Call StatisticsRecorder::Initialize in GlobalHistogramAllocator's ctor (Closed)
Patch Set: hack3 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/persistent_histogram_allocator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/histogram_tester_unittest.cc
diff --git a/base/test/histogram_tester_unittest.cc b/base/test/histogram_tester_unittest.cc
index c4d49af942f783a571b270a591c5b2faaee85e03..bc3ab2cbf52a67890716cd92e0ce0dfe58353e12 100644
--- a/base/test/histogram_tester_unittest.cc
+++ b/base/test/histogram_tester_unittest.cc
@@ -8,11 +8,11 @@
#include "base/metrics/histogram_macros.h"
#include "base/metrics/histogram_samples.h"
-#include "testing/gmock/include/gmock/gmock.h"
+//#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using ::testing::ElementsAre;
-using ::testing::IsEmpty;
+//using ::testing::ElementsAre;
+//using ::testing::IsEmpty;
namespace {
@@ -20,7 +20,9 @@ const char kHistogram1[] = "Test1";
const char kHistogram2[] = "Test2";
const char kHistogram3[] = "Test3";
const char kHistogram4[] = "Test4";
+#if 0
const char kHistogram5[] = "Test5";
+#endif
} // namespace
@@ -101,6 +103,7 @@ TEST_F(HistogramTesterTest, TestBucketsSampleWithScope) {
tester.ExpectTotalCount(kHistogram4, 1);
}
+#if 0
TEST_F(HistogramTesterTest, TestGetAllSamples) {
HistogramTester tester;
UMA_HISTOGRAM_ENUMERATION(kHistogram5, 2, 5);
@@ -116,5 +119,6 @@ TEST_F(HistogramTesterTest, TestGetAllSamples_NoSamples) {
HistogramTester tester;
EXPECT_THAT(tester.GetAllSamples(kHistogram5), IsEmpty());
}
+#endif
} // namespace base
« no previous file with comments | « base/metrics/persistent_histogram_allocator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698