Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2354333008: Fix use-after-scope in SharedStyleFinderTest. (Closed)

Created:
4 years, 3 months ago by krasin1
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10, esprehn, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-after-scope in SharedStyleFinderTest. SharedStyleFinderTest::matchesRuleSet created a ElementResolveContext instance and passed a reference to SharedStyleFinder. Then the scope of the context is ended, and finder retains a reference to an address on stack that ends up being reused. It was detected by 'ThinLTO Linux ToT' bot, but it seems to be just a coincedence. BUG=645295 Committed: https://crrev.com/25782de6522c605860d6e0fc265b164f3d567442 Cr-Commit-Position: refs/heads/master@{#420879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
krasin1
4 years, 3 months ago (2016-09-24 00:55:37 UTC) #2
meade_UTC10
lgtm
4 years, 2 months ago (2016-09-26 03:12:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354333008/1
4 years, 2 months ago (2016-09-26 03:20:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/266467)
4 years, 2 months ago (2016-09-26 03:28:08 UTC) #11
krasin1
Hi Elliott, please, approve this one-liner.
4 years, 2 months ago (2016-09-26 03:31:52 UTC) #13
rune
lgtm
4 years, 2 months ago (2016-09-26 06:48:59 UTC) #15
krasin1
On 2016/09/26 06:48:59, rune wrote: > lgtm Thank you!
4 years, 2 months ago (2016-09-26 06:55:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354333008/1
4 years, 2 months ago (2016-09-26 06:56:08 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 10:40:14 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 10:42:26 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25782de6522c605860d6e0fc265b164f3d567442
Cr-Commit-Position: refs/heads/master@{#420879}

Powered by Google App Engine
This is Rietveld 408576698