|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by krasin1 Modified:
4 years, 2 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix use-after-scope in SharedStyleFinderTest.
SharedStyleFinderTest::matchesRuleSet created a
ElementResolveContext instance and passed a reference
to SharedStyleFinder. Then the scope of the context
is ended, and finder retains a reference to an address
on stack that ends up being reused.
It was detected by 'ThinLTO Linux ToT' bot, but it
seems to be just a coincedence.
BUG=645295
Committed: https://crrev.com/25782de6522c605860d6e0fc265b164f3d567442
Cr-Commit-Position: refs/heads/master@{#420879}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
krasin@chromium.org changed reviewers: + meade@chromium.org
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
krasin@chromium.org changed reviewers: + esprehn@chromium.org
Hi Elliott, please, approve this one-liner.
rune@opera.com changed reviewers: + rune@opera.com
lgtm
On 2016/09/26 06:48:59, rune wrote: > lgtm Thank you!
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix use-after-scope in SharedStyleFinderTest. SharedStyleFinderTest::matchesRuleSet created a ElementResolveContext instance and passed a reference to SharedStyleFinder. Then the scope of the context is ended, and finder retains a reference to an address on stack that ends up being reused. It was detected by 'ThinLTO Linux ToT' bot, but it seems to be just a coincedence. BUG=645295 ========== to ========== Fix use-after-scope in SharedStyleFinderTest. SharedStyleFinderTest::matchesRuleSet created a ElementResolveContext instance and passed a reference to SharedStyleFinder. Then the scope of the context is ended, and finder retains a reference to an address on stack that ends up being reused. It was detected by 'ThinLTO Linux ToT' bot, but it seems to be just a coincedence. BUG=645295 Committed: https://crrev.com/25782de6522c605860d6e0fc265b164f3d567442 Cr-Commit-Position: refs/heads/master@{#420879} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/25782de6522c605860d6e0fc265b164f3d567442 Cr-Commit-Position: refs/heads/master@{#420879} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
