third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp - Issue 2354333008: Fix use-after-scope in SharedStyleFinderTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

Issue 2354333008: Fix use-after-scope in SharedStyleFinderTest. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

index 7c8a4ad2702609145fbcea9f93a97a2f926d5840..840947fd34c945c30465eed10aef68baea7e4b68 100644

--- a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

@@ -68,7 +68,8 @@ private:

if (!ruleSet)

return false;

- SharedStyleFinder finder(ElementResolveContext(element),

+ ElementResolveContext context(element);

+ SharedStyleFinder finder(context,

m_ruleSet->features(),

m_siblingRuleSet,

m_uncommonAttributeRuleSet,

« no previous file with comments | « no previous file | no next file » | no next file with comments »