Issue 23543002: Add an IPC to abort Stream construction.

Issue 23543002: Add an IPC to abort Stream construction. (Closed)

Created:
7 years, 3 months ago by tyoshino (SeeGerritForStatus)

Modified:
7 years, 3 months ago

Reviewers:
kinuko, Tom Sepez, jam

CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an IPC to abort Stream construction. To be used by XHR to abort partially constructed Stream. https://codereview.chromium.org/18883002/ BUG=169957 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220009

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -4 lines)			Patch
M	content/browser/fileapi/fileapi_message_filter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/streams/stream.h	View	2 chunks	+4 lines, -4 lines	1 comment	Download
M	content/child/webblobregistry_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/webblobregistry_impl.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/common/fileapi/webblob_messages.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

As usual, please review - kinuko: whole CL - jam: as an OWNER - tsepez: ...

7 years, 3 months ago (2013-08-27 12:07:48 UTC) #2

kinuko

lgtm https://codereview.chromium.org/23543002/diff/1/content/browser/streams/stream.h File content/browser/streams/stream.h (right): https://codereview.chromium.org/23543002/diff/1/content/browser/streams/stream.h#newcode63 content/browser/streams/stream.h:63: void Abort(); (ok this looks to be the ...

7 years, 3 months ago (2013-08-27 13:35:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/23543002/1

7 years, 3 months ago (2013-08-28 08:12:18 UTC) #6

Message was sent while issue was closed.

Change committed as 220009

Expand Messages | Collapse Messages