Disable direct routing of mouse events for RenderWidgetHostViewGuest

Disable direct routing of mouse events for RenderWidgetHostViewGuest

When --isolate-extensions became enabled by default, a consequence is
that it turned on by default direct browser-side routing of mouse events
to webviews, even though RenderWidgetHostViewGuest has not been
modified to support that. This has resulted in multiple input-related
regressions.

This CL disables direct routing to fix those problems. Mouse events
will once again be sent to the embedding renderer process and returned
to the BrowserPluginGuest to be dispatched to the guest.

BUG=648921
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7dfa73aa45e87390c8d20ca31ac69a1cf5a91e0e
Cr-Commit-Position: refs/heads/master@{#420168}

[kenrb, 2016-09-21 16:26:26]

Description was changed from

==========
Disable direct routing of mouse events for RenderWidgetHostViewGuest

When --isolate-extensions became enabled by default, a consequence is
that it turned on by default direct browser-side routing of mouse events
to webviews, even though RenderWidgetHostViewGuest has not been
modified to support that. This has resulted in multiple input-related
regressions.

This CL disables direct routing to fix those problems. Mouse events
will once again be sent to the embedding renderer process and returned
to the BrowserPluginGuest to be dispatched to the guest.

BUG=648921
==========

to

==========
Disable direct routing of mouse events for RenderWidgetHostViewGuest

When --isolate-extensions became enabled by default, a consequence is
that it turned on by default direct browser-side routing of mouse events
to webviews, even though RenderWidgetHostViewGuest has not been
modified to support that. This has resulted in multiple input-related
regressions.

This CL disables direct routing to fix those problems. Mouse events
will once again be sent to the embedding renderer process and returned
to the BrowserPluginGuest to be dispatched to the guest.

BUG=648921
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[kenrb, 2016-09-21 16:26:53]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 16:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 16:42:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-09-21 16:48:52]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:49:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 17:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 17:05:40]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[kenrb, 2016-09-21 17:16:08]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 17:16:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2016-09-21 18:04:47]

kenrb@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[kenrb, 2016-09-21 18:04:48]

wjmaclean: Does this look reasonable?

[commit-bot: I haz the power, 2016-09-21 18:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:07:26]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2016-09-21 18:34:53]

One question within, otherwise lgtm.

https://codereview.chromium.org/2354283003/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/2354283003/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:199:
root_view->ProcessMouseEvent(*event, latency);
Do we always want to go to the root? This will work in most cases, but could we
have a WebView embedded in a cross-site iframe? If that doesn't happen, then
this is fine.

[kenrb, 2016-09-21 18:56:35]

kenrb@chromium.org changed reviewers:
+ nick@chromium.org

[kenrb, 2016-09-21 18:56:36]

nick: PTAL for owner review?

https://codereview.chromium.org/2354283003/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/2354283003/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:199:
root_view->ProcessMouseEvent(*event, latency);
On 2016/09/21 18:34:52, wjmaclean wrote:
> Do we always want to go to the root? This will work in most cases, but could
we
> have a WebView embedded in a cross-site iframe? If that doesn't happen, then
> this is fine.

WebViews can't be embedded by web content, so AFAIK this should be okay.

[ncarter (slow), 2016-09-21 21:02:26]

lgtm

[kenrb, 2016-09-21 21:35:57]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:36:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:43:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 21:47:17]

Description was changed from

==========
Disable direct routing of mouse events for RenderWidgetHostViewGuest

When --isolate-extensions became enabled by default, a consequence is
that it turned on by default direct browser-side routing of mouse events
to webviews, even though RenderWidgetHostViewGuest has not been
modified to support that. This has resulted in multiple input-related
regressions.

This CL disables direct routing to fix those problems. Mouse events
will once again be sent to the embedding renderer process and returned
to the BrowserPluginGuest to be dispatched to the guest.

BUG=648921
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable direct routing of mouse events for RenderWidgetHostViewGuest

When --isolate-extensions became enabled by default, a consequence is
that it turned on by default direct browser-side routing of mouse events
to webviews, even though RenderWidgetHostViewGuest has not been
modified to support that. This has resulted in multiple input-related
regressions.

This CL disables direct routing to fix those problems. Mouse events
will once again be sent to the embedding renderer process and returned
to the BrowserPluginGuest to be dispatched to the guest.

BUG=648921
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7dfa73aa45e87390c8d20ca31ac69a1cf5a91e0e
Cr-Commit-Position: refs/heads/master@{#420168}
==========

[commit-bot: I haz the power, 2016-09-21 21:47:19]

Patchset 4 (id:??) landed as
https://crrev.com/7dfa73aa45e87390c8d20ca31ac69a1cf5a91e0e
Cr-Commit-Position: refs/heads/master@{#420168}