Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: content/browser/renderer_host/render_widget_host_input_event_router.cc

Issue 2354283003: Disable direct routing of mouse events for RenderWidgetHostViewGuest (Closed)
Patch Set: Tweak Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_input_event_router.cc
diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.cc b/content/browser/renderer_host/render_widget_host_input_event_router.cc
index 68b19afed29ace6e202658fbb5c6eb2ea06a19c2..8ad60fe3b5955a94014e2741ac3067d6e121e4b8 100644
--- a/content/browser/renderer_host/render_widget_host_input_event_router.cc
+++ b/content/browser/renderer_host/render_widget_host_input_event_router.cc
@@ -192,6 +192,14 @@ void RenderWidgetHostInputEventRouter::RouteMouseEvent(
&transformed_point);
}
+ // RenderWidgetHostViewGuest does not properly handle direct routing of mouse
+ // events, so they have to go by the double-hop forwarding path through
+ // the embedding renderer and then BrowserPluginGuest.
+ if (target && target->IsRenderWidgetHostViewGuest()) {
+ root_view->ProcessMouseEvent(*event, latency);
wjmaclean 2016/09/21 18:34:52 Do we always want to go to the root? This will wor
kenrb 2016/09/21 18:56:36 WebViews can't be embedded by web content, so AFAI
+ return;
+ }
+
if (event->type == blink::WebInputEvent::MouseDown)
mouse_capture_target_.target = target;

Powered by Google App Engine
This is Rietveld 408576698