Remove window.moveTo calls from picker-common.js

Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671
Committed: https://crrev.com/f8386d1d8f1268ef794fafef76d7dd5b372367a9
Cr-Commit-Position: refs/heads/master@{#420557}

[bokan, 2016-09-21 15:30:21]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 15:30:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 17:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 17:42:08]

Dry run: This issue passed the CQ dry run.

[bokan, 2016-09-21 17:54:52]

Description was changed from

==========
Fix

BUG=
==========

to

==========
Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671
==========

[bokan, 2016-09-21 17:54:53]

bokan@chromium.org changed reviewers:
+ keishi@chromium.org

[bokan, 2016-09-21 17:56:20]

keishi@, I believe these are unneeded as all layout tests still pass. When
fixing a bug in the popup move/size code in
https://codereview.chromium.org/2333353002/ these moveTos are causing failures
because the window returns coordinates "as if" it moved, but the browser doesn't
actually move the window. (window.moveTo doesn't work on non window.open'ed
windows).

[keishi, 2016-09-22 15:09:00]

LGTM

https://codereview.chromium.org/2354273002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
(right):

https://codereview.chromium.org/2354273002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js:69: // We
need to move the window to the top left of available space
nit: This comment and this function should also be removed.

[bokan, 2016-09-23 00:53:54]

https://codereview.chromium.org/2354273002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
(right):

https://codereview.chromium.org/2354273002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js:69: // We
need to move the window to the top left of available space
On 2016/09/22 15:08:59, keishi wrote:
> nit: This comment and this function should also be removed.

Done.

[bokan, 2016-09-23 00:53:58]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-09-23 00:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/2354273002/#ps20001
(title: "Removed Comment")

[commit-bot: I haz the power, 2016-09-23 00:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:04:11]

Description was changed from

==========
Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671
==========

to

==========
Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671
==========

[commit-bot: I haz the power, 2016-09-23 03:04:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 03:06:22]

Description was changed from

==========
Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671
==========

to

==========
Remove window.moveTo calls from picker-common.js

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671

Committed: https://crrev.com/f8386d1d8f1268ef794fafef76d7dd5b372367a9
Cr-Commit-Position: refs/heads/master@{#420557}
==========

[commit-bot: I haz the power, 2016-09-23 03:06:23]

Patchset 2 (id:??) landed as
https://crrev.com/f8386d1d8f1268ef794fafef76d7dd5b372367a9
Cr-Commit-Position: refs/heads/master@{#420557}