Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

Issue 2354273002: Remove window.moveTo calls from picker-common.js (Closed)
Patch Set: Removed Comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
diff --git a/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js b/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
index 5f87bff96bff902f36f6ed90fe940fe78d05f356..10f89da6b1c3ed37b6aafd37b7fcbcf0c4fcf2d7 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
+++ b/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js
@@ -34,7 +34,6 @@ function rootWindow() {
// - INPUT color with DATALIST
// - INPUT date/datetime-local/month/week
function openPicker(element, callback, errorCallback) {
- rootWindow().moveTo(window.screenX, window.screenY);
element.offsetTop; // Force to lay out
element.focus();
if (element.tagName === "SELECT") {
@@ -54,7 +53,6 @@ function openPicker(element, callback, errorCallback) {
}
function clickToOpenPicker(x, y, callback, errorCallback) {
- rootWindow().moveTo(window.screenX, window.screenY);
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
eventSender.mouseUp();
@@ -67,13 +65,7 @@ function clickToOpenPicker(x, y, callback, errorCallback) {
function setPopupOpenCallback(callback) {
console.assert(popupWindow);
- popupOpenCallback = (function(callback) {
- // We need to move the window to the top left of available space
- // because the window will move back to (0, 0) when the
- // ShellViewMsg_SetTestConfiguration IPC arrives.
- rootWindow().moveTo(window.screenX, window.screenY);
- callback();
- }).bind(this, callback);
+ popupOpenCallback = callback;
try {
popupWindow.addEventListener("didOpenPicker", popupOpenCallbackWrapper, false);
} catch(e) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698