Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2354263002: [turbofan] Add early detection of object state cycles. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add early detection of object state cycles. This makes sure cycles in the object states graph are detected early by escape analysis instead of late in the scheduler. This is mainly done for improved debuggability. R=bmeurer@chromium.org BUG=chromium:613923 Committed: https://crrev.com/59a38a9ac813768e734a0bc54473c0d287151ad9 Cr-Commit-Position: refs/heads/master@{#39614}

Patch Set 1 #

Patch Set 2 : Disable one test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M src/compiler/escape-analysis.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/escape-analysis.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-21 15:52:10 UTC) #7
Benedikt Meurer
Nice. LGTM.
4 years, 3 months ago (2016-09-21 18:19:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354263002/20001
4 years, 3 months ago (2016-09-22 07:47:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 07:50:09 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 07:51:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59a38a9ac813768e734a0bc54473c0d287151ad9
Cr-Commit-Position: refs/heads/master@{#39614}

Powered by Google App Engine
This is Rietveld 408576698