Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: src/compiler/escape-analysis-reducer.cc

Issue 2354263002: [turbofan] Add early detection of object state cycles. (Closed)
Patch Set: Disable one test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/escape-analysis.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/escape-analysis-reducer.cc
diff --git a/src/compiler/escape-analysis-reducer.cc b/src/compiler/escape-analysis-reducer.cc
index c69b86c488ddfb7ccb7016f0d6ac984be28e4ffe..a2b53c0b875b5b54e9feac606e3939cab6f9226a 100644
--- a/src/compiler/escape-analysis-reducer.cc
+++ b/src/compiler/escape-analysis-reducer.cc
@@ -305,6 +305,11 @@ Node* EscapeAnalysisReducer::ReduceStateValueInput(Node* node, int node_index,
if (input->opcode() == IrOpcode::kFinishRegion ||
input->opcode() == IrOpcode::kAllocate) {
if (escape_analysis()->IsVirtual(input)) {
+ if (escape_analysis()->IsCyclicObjectState(effect, input)) {
+ // TODO(mstarzinger): Represent cyclic object states differently to
+ // ensure the scheduler can properly handle such object states.
+ FATAL("Cyclic object state detected by escape analysis.");
+ }
if (Node* object_state =
escape_analysis()->GetOrCreateObjectState(effect, input)) {
if (node_multiused || (multiple_users && !already_cloned)) {
« no previous file with comments | « src/compiler/escape-analysis.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698