Issue 235423004: Disable WebViewTest.SpeechRecognition, InputTagSpeechBrowserTest.GrammarAttribute and InputTagSpeec…

Issue 235423004: Disable WebViewTest.SpeechRecognition, InputTagSpeechBrowserTest.GrammarAttribute and InputTagSpeec… (Closed)

Created:
6 years, 8 months ago by Ronghua Wu (Left Chromium)

Modified:
6 years, 8 months ago

Reviewers:
Fady Samuel, jschuh, tommi (sloooow) - chröme, hans

CC:
chromium-reviews, darin-cc_chromium.org, jam, eseidel, Tommy Widenflycht

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Disable WebViewTest.SpeechRecognition, InputTagSpeechBrowserTest.GrammarAttribute and InputTagSpeechBrowserTest.TestBasicRecognition in order to reland https://codereview.chromium.org/231323003. TEST=try bots R=fsamuel@chromium.org, jschuh@chromium.org TBR=tommi BUG=360448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263369

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/apps/web_view_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	content/browser/speech/input_tag_speech_browsertest.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 8 (0 generated)

Ronghua Wu (Left Chromium)

+fsamuel and tommi for owner approval.

6 years, 8 months ago (2014-04-11 18:33:26 UTC) #3

Ronghua Wu (Left Chromium)

+hans for the owner approval for content/browser/speech/input_tag_speech_browsertest.cc

6 years, 8 months ago (2014-04-11 21:14:15 UTC) #5

Ronghua Wu (Left Chromium)

Looks like tommi and hans are all out. Need this cl today to land another ...

6 years, 8 months ago (2014-04-11 21:41:13 UTC) #6

Ronghua Wu (Left Chromium)

Committed patchset #2 manually as r263369 (presubmit successful).

6 years, 8 months ago (2014-04-11 21:52:32 UTC) #7

hans

6 years, 8 months ago (2014-04-14 16:04:11 UTC) #8

Message was sent while issue was closed.

On 2014/04/11 21:52:32, Ronghua Wu wrote:
> Committed patchset #2 manually as r263369 (presubmit successful).

lgtm, thanks for pushing this through