Disable x-webkit-speech

Disable x-webkit-speech

This does not remove the code yet, only makes x-webkit-speech
test-only (only exposed during LayoutTests) which makes
this patch only a one-line change. We should follow up this
change with a full removal of this feature including
all tests.

x-webkit-speech is a Chrome-only feature which was
announced as deprecated Feb 2014:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlPdpx6jErE
Current usage is at about 0.487% of reported Chrome page views
which is (well) above our normal 0.06% removal threshold:
http://www.chromestatus.com/metrics/feature/popularity#PrefixedSpeechAttribute

However, hours ago we recieved report of cases where *requiring
user interaction* speech can be captured for up to 8 seconds
or until the user stops un-interrupted speaking without proper
appearance of the "Allow this site to use your microphone"
infobar.

Although this is only a medium-security issue (requires
user interaction and very limited duration), this is still
severe enough that we no longer believe we can support
this deprecated, webkit-only feature.

Removing this feature will not affect mobile users
which already have access to speech-input via various
speech-enabled keyboards on Android.  Desktop sites which
were using this feature can use the modern Web Speech APIs
instead, which are standardized and supported accross many
browsers: http://caniuse.com/web-speech

Without this feature pages will continue to work, they just
will not be able to get speech input via <input> controls
via these APIs and will either have to use the standard
Web Speech APIs or depend on the operating system to expose
speech input via other methods.

I've verified that disabling this does not affect the new
JS Web Speech API by testing with:
https://www.google.com/intl/en/chrome/demos/speech.html

BUG=360448
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171187

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171373

[Tommy Widenflycht, 2014-04-09 19:21:16]

unfortunately this change doesn't disable the speech recognition bubble;

[Tommy Widenflycht, 2014-04-09 19:44:50]

On 2014/04/09 19:21:16, Tommy Widenflycht wrote:
> unfortunately this change doesn't disable the speech recognition bubble;

I goofed up. This patch does the trick all right.

[Tommy Widenflycht, 2014-04-09 19:45:00]

lgtm

[jschuh, 2014-04-09 20:07:16]

lgtm

[commit-bot: I haz the power, 2014-04-09 20:07:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/231323003/1

[commit-bot: I haz the power, 2014-04-09 20:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-09 20:07:28]

Failed to apply patch for Source/platform/RuntimeEnabledFeatures.in:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/RuntimeEnabledFeatures.in
  Hunk #1 FAILED at 104.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/platform/RuntimeEnabledFeatures.in.rej

Patch:       Source/platform/RuntimeEnabledFeatures.in
Index: Source/platform/RuntimeEnabledFeatures.in
diff --git a/Source/platform/RuntimeEnabledFeatures.in
b/Source/platform/RuntimeEnabledFeatures.in
index
fa92bf9c5dd236e251d84ca9b5d53ea2e042d03e..477290f68783b90fd26d47d1843e557c20d74db1
100644
--- a/Source/platform/RuntimeEnabledFeatures.in
+++ b/Source/platform/RuntimeEnabledFeatures.in
@@ -104,7 +104,7 @@ ScrollTopLeftInterop status=experimental
 ServiceWorker status=experimental
 SessionStorage status=stable
 SharedWorker status=stable
-SpeechInput status=stable
+SpeechInput status=test
 SpeechSynthesis status=stable
 Srcset status=stable
 Stream status=experimental

[eseidel, 2014-04-09 21:04:48]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-09 21:04:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/231323003/20001

[commit-bot: I haz the power, 2014-04-09 22:08:32]

Change committed as 171187

[eseidel, 2014-04-10 05:20:55]

This got rolled out due to breaking browser_tests which are not covered by the
Blink CQ.

[jschuh, 2014-04-11 22:05:53]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-04-11 22:05:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/231323003/20001

[commit-bot: I haz the power, 2014-04-11 22:06:29]

Change committed as 171373