Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 23542056: path ops work in progress (Closed)

Created:
7 years, 3 months ago by caryclark
Modified:
7 years, 2 months ago
Reviewers:
CC:
skia-review_googlegroups.com, tfarina
Visibility:
Public.

Description

path ops work in progress make more skps work remove edit files BUG= Committed: https://code.google.com/p/skia/source/detail?r=11570

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : fix whitespace #

Patch Set 4 : fix more skps #

Patch Set 5 : fix skps #

Patch Set 6 : fix skps #

Patch Set 7 : make more skps work #

Patch Set 8 : fix more skps #

Patch Set 9 : fix spaces #

Patch Set 10 : fix space #

Patch Set 11 : fix linux 32 #

Patch Set 12 : check for intersection overflow #

Patch Set 13 : verbose + mutex around file number access #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2475 lines, -342 lines) Patch
M gyp/pathops_unittest.gyp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M gyp/pathops_unittest.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkAddIntersections.cpp View 1 2 3 4 5 6 2 chunks +16 lines, -7 lines 0 comments Download
M src/pathops/SkDCubicIntersection.cpp View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +103 lines, -63 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +18 lines, -0 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +71 lines, -44 lines 0 comments Download
M src/pathops/SkDQuadImplicit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkDQuadIntersection.cpp View 1 2 3 4 5 6 7 8 9 10 11 9 chunks +35 lines, -28 lines 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkIntersectionHelper.h View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M src/pathops/SkIntersections.h View 1 2 3 4 5 6 7 8 9 10 11 15 chunks +27 lines, -2 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +8 lines, -1 line 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 2 3 4 5 6 7 8 3 chunks +19 lines, -5 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 1 2 3 4 5 6 7 chunks +67 lines, -25 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 5 6 7 8 9 22 chunks +106 lines, -35 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 2 chunks +25 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsPoint.h View 1 2 chunks +35 lines, -18 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 6 chunks +47 lines, -0 lines 0 comments Download
M src/pathops/SkPathWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkQuarticRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 3 10 chunks +51 lines, -4 lines 0 comments Download
M tests/PathOpsCubicIntersectionTestData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
M tests/PathOpsCubicReduceOrderTest.cpp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +25 lines, -16 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 4 chunks +47 lines, -2 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 5 6 7 8 9 10 9 chunks +784 lines, -12 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M tests/PathOpsQuadIntersectionTestData.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 3 4 5 6 7 1 chunk +16 lines, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 2 3 4 5 6 7 8 9 5 chunks +180 lines, -37 lines 0 comments Download
A tests/PathOpsSkpTest.cpp View 1 2 3 4 5 6 7 1 chunk +703 lines, -0 lines 0 comments Download
M tests/PathOpsThreadedCommon.h View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
caryclark
Committed patchset #13 manually as r11570 (presubmit successful).
7 years, 2 months ago (2013-10-02 14:50:02 UTC) #1
tfarina
7 years, 2 months ago (2013-10-02 16:25:48 UTC) #2
Message was sent while issue was closed.
I'd love to see some kind of description, an overview of what is going on in
this "path ops" patch series.

It's a little frustating to come and see such huge CLs (and certainly complex)
without any information for future reference (what is about, what they are
doing, fixing, improving, why, etc).

Powered by Google App Engine
This is Rietveld 408576698