Simplify installing concurrently recompiled code.

Simplify installing concurrently recompiled code.

Instead of overwriting the code entry of the function, we trigger
an interrupt to install the code on the main thread.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=16681

[Michael Starzinger, 2013-09-12 10:53:10]

LGTM if all comments are addressed.

https://codereview.chromium.org/23542029/diff/4001/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/23542029/diff/4001/src/execution.cc#newcode953
src/execution.cc:953: if (FLAG_concurrent_recompilation &&
stack_guard->IsInstallCodeRequest()) {
We should only receive this stack guard request of concurrent compilation is
active, so instead of checking the flag here, I would just put an assert into
the conditional block.

https://codereview.chromium.org/23542029/diff/4001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/23542029/diff/4001/src/ia32/builtins-ia32.cc#...
src/ia32/builtins-ia32.cc:105: // Check stack limit for signal to install code.
As discussed offline: Since this stack-check is only an optimization and not
needed for functionality, can we add a comment explaining that? Applies to all
architectures.

https://codereview.chromium.org/23542029/diff/4001/src/objects.h
File src/objects.h (left):

https://codereview.chromium.org/23542029/diff/4001/src/objects.h#oldcode7005
src/objects.h:7005: void MarkForInstallingRecompiledCode();
The implementation of MarkForInstallingRecompiledCode, let's remove the
declaration as well.

[Yang, 2013-09-12 11:31:19]

Committed patchset #2 manually as r16681 (presubmit successful).