Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/debug.cc

Issue 23542029: Simplify installing concurrently recompiled code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: add stack check when calling function that is in recompile queue. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2092 matching lines...) Expand 10 before | Expand all | Expand 10 after
2103 if (!shared->allows_lazy_compilation()) continue; 2103 if (!shared->allows_lazy_compilation()) continue;
2104 if (!shared->script()->IsScript()) continue; 2104 if (!shared->script()->IsScript()) continue;
2105 if (shared->code()->gc_metadata() == active_code_marker) continue; 2105 if (shared->code()->gc_metadata() == active_code_marker) continue;
2106 2106
2107 Code::Kind kind = function->code()->kind(); 2107 Code::Kind kind = function->code()->kind();
2108 if (kind == Code::FUNCTION && 2108 if (kind == Code::FUNCTION &&
2109 !function->code()->has_debug_break_slots()) { 2109 !function->code()->has_debug_break_slots()) {
2110 function->set_code(*lazy_compile); 2110 function->set_code(*lazy_compile);
2111 function->shared()->set_code(*lazy_compile); 2111 function->shared()->set_code(*lazy_compile);
2112 } else if (kind == Code::BUILTIN && 2112 } else if (kind == Code::BUILTIN &&
2113 (function->IsMarkedForInstallingRecompiledCode() || 2113 (function->IsInRecompileQueue() ||
2114 function->IsInRecompileQueue() ||
2115 function->IsMarkedForLazyRecompilation() || 2114 function->IsMarkedForLazyRecompilation() ||
2116 function->IsMarkedForConcurrentRecompilation())) { 2115 function->IsMarkedForConcurrentRecompilation())) {
2117 // Abort in-flight compilation. 2116 // Abort in-flight compilation.
2118 Code* shared_code = function->shared()->code(); 2117 Code* shared_code = function->shared()->code();
2119 if (shared_code->kind() == Code::FUNCTION && 2118 if (shared_code->kind() == Code::FUNCTION &&
2120 shared_code->has_debug_break_slots()) { 2119 shared_code->has_debug_break_slots()) {
2121 function->set_code(shared_code); 2120 function->set_code(shared_code);
2122 } else { 2121 } else {
2123 function->set_code(*lazy_compile); 2122 function->set_code(*lazy_compile);
2124 function->shared()->set_code(*lazy_compile); 2123 function->shared()->set_code(*lazy_compile);
(...skipping 1724 matching lines...) Expand 10 before | Expand all | Expand 10 after
3849 { 3848 {
3850 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3849 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3851 isolate_->debugger()->CallMessageDispatchHandler(); 3850 isolate_->debugger()->CallMessageDispatchHandler();
3852 } 3851 }
3853 } 3852 }
3854 } 3853 }
3855 3854
3856 #endif // ENABLE_DEBUGGER_SUPPORT 3855 #endif // ENABLE_DEBUGGER_SUPPORT
3857 3856
3858 } } // namespace v8::internal 3857 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/execution.h » ('j') | src/execution.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698