Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2354193002: Revert "MD History: promote menu button to show clear browsing data in narrow mode" (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asanka, dbeam+watch-elements_chromium.org, jlklein+watch-closure_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "MD History: promote menu button to show clear browsing data in narrow mode" This reverts commit 2d6fa4fda96dd212548f8422cf589224eb305766. https://chromium.googlesource.com/chromium/src/+/2d6fa4fda96dd212548f8422cf589224eb305766 Speculative revert, Google Chrome Win fails to compile due to MdHistoryUI link errors, which has closed the tree. See: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/11064/ Manual revert because "Revert patchset" button failed ("file too large"). BUG=598017 TBR=dbeam@chromium.org,tsergeant@chromium.org,pam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=True NOTREECHECKS=True

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -471 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +1 line, -28 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 2 chunks +3 lines, -60 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 5 chunks +73 lines, -112 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 5 chunks +5 lines, -62 lines 0 comments Download
M chrome/browser/resources/md_history/browser_service.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 2 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.js View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 8 chunks +3 lines, -26 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html View 2 chunks +3 lines, -62 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js View 3 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 09:01:16 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698