Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/ui/webui/md_history_ui.cc

Issue 2354193002: Revert "MD History: promote menu button to show clear browsing data in narrow mode" (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/md_history_ui.h ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/md_history_ui.cc
diff --git a/chrome/browser/ui/webui/md_history_ui.cc b/chrome/browser/ui/webui/md_history_ui.cc
index e6b721ffdae91558b0721d33ad76571d11d3f725..2b1d688ae963a987b5ce7a1c9f6cbf1026a14ae8 100644
--- a/chrome/browser/ui/webui/md_history_ui.cc
+++ b/chrome/browser/ui/webui/md_history_ui.cc
@@ -4,8 +4,6 @@
#include "chrome/browser/ui/webui/md_history_ui.h"
-#include "base/bind.h"
-#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
@@ -23,7 +21,6 @@
#include "chrome/grit/locale_settings.h"
#include "chrome/grit/theme_resources.h"
#include "components/grit/components_scaled_resources.h"
-#include "components/pref_registry/pref_registry_syncable.h"
#include "components/prefs/pref_service.h"
#include "components/search/search.h"
#include "components/signin/core/browser/signin_manager.h"
@@ -36,6 +33,8 @@
namespace {
content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
+ PrefService* prefs = profile->GetPrefs();
+
content::WebUIDataSource* source =
content::WebUIDataSource::Create(chrome::kChromeUIHistoryHost);
@@ -45,7 +44,6 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
source->AddLocalizedString("clearBrowsingData",
IDS_CLEAR_BROWSING_DATA_TITLE);
source->AddLocalizedString("clearSearch", IDS_MD_HISTORY_CLEAR_SEARCH);
- source->AddLocalizedString("closeMenuPromo", IDS_MD_HISTORY_CLOSE_MENU_PROMO);
source->AddLocalizedString("collapseSessionButton",
IDS_HISTORY_OTHER_SESSIONS_COLLAPSE_SESSION);
source->AddLocalizedString("delete", IDS_MD_HISTORY_DELETE);
@@ -71,7 +69,6 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
IDS_MD_HISTORY_HISTORY_MENU_ITEM);
source->AddLocalizedString("itemsSelected", IDS_MD_HISTORY_ITEMS_SELECTED);
source->AddLocalizedString("loading", IDS_HISTORY_LOADING);
- source->AddLocalizedString("menuPromo", IDS_MD_HISTORY_MENU_PROMO);
source->AddLocalizedString("moreActionsButton",
IDS_HISTORY_ACTION_MENU_DESCRIPTION);
source->AddLocalizedString("moreFromSite", IDS_HISTORY_MORE_FROM_SITE);
@@ -108,14 +105,10 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
l10n_util::GetStringUTF16(
IDS_SETTINGS_CLEAR_DATA_WEB_HISTORY_URL_IN_HISTORY)));
- PrefService* prefs = profile->GetPrefs();
bool allow_deleting_history =
prefs->GetBoolean(prefs::kAllowDeletingBrowserHistory);
source->AddBoolean("allowDeletingHistory", allow_deleting_history);
- source->AddBoolean("showMenuPromo",
- !prefs->GetBoolean(prefs::kMdHistoryMenuPromoShown));
-
bool group_by_domain = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kHistoryEnableGroupByDomain) || profile->IsSupervised();
source->AddBoolean("groupByDomain", group_by_domain);
@@ -208,11 +201,7 @@ MdHistoryUI::MdHistoryUI(content::WebUI* web_ui) : WebUIController(web_ui) {
web_ui->AddMessageHandler(new HistoryLoginHandler());
}
- data_source_ = CreateMdHistoryUIHTMLSource(profile);
- content::WebUIDataSource::Add(profile, data_source_);
-
- web_ui->RegisterMessageCallback("menuPromoShown",
- base::Bind(&MdHistoryUI::HandleMenuPromoShown, base::Unretained(this)));
+ content::WebUIDataSource::Add(profile, CreateMdHistoryUIHTMLSource(profile));
}
MdHistoryUI::~MdHistoryUI() {}
@@ -242,15 +231,3 @@ base::RefCountedMemory* MdHistoryUI::GetFaviconResourceBytes(
return ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
IDR_HISTORY_FAVICON, scale_factor);
}
-
-void MdHistoryUI::RegisterProfilePrefs(
- user_prefs::PrefRegistrySyncable* registry) {
- registry->RegisterBooleanPref(prefs::kMdHistoryMenuPromoShown, false,
- user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
-}
-
-void MdHistoryUI::HandleMenuPromoShown(const base::ListValue* args) {
- Profile::FromWebUI(web_ui())->GetPrefs()->SetBoolean(
- prefs::kMdHistoryMenuPromoShown, true);
- data_source_->AddBoolean("showMenuPromo", false);
-}
« no previous file with comments | « chrome/browser/ui/webui/md_history_ui.h ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698