History: Fix flicker of sync notices when loading new data

History: Fix flicker of sync notices when loading new data

The history page shows a notice when showing synced results from other
devices. This notice would frequently flicker when loading in new
results (eg, from a search), which was particularly noticable on the MD
History page, where this can cause toolbar elements to move around.

This fixes the issue by only resetting notice status back to false
when there is no web history service. In all other cases, we can
rely on the call to web history to reset the sync notices to their
correct values.

BUG=628555
Committed: https://crrev.com/462304822ad58b7755e9de924c8cda4af093160e
Cr-Commit-Position: refs/heads/master@{#420220}

[tsergeant, 2016-09-21 03:42:56]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 03:43:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-21 03:46:28]

tsergeant@chromium.org changed reviewers:
+ msramek@chromium.org

[tsergeant, 2016-09-21 03:46:28]

Hi msramek@, PTAL. Please let me know if this is the right behavior from a
privacy perspective, or if you have any other ideas for how to solve this bug.

Thanks!

[commit-bot: I haz the power, 2016-09-21 04:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 04:42:20]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-09-21 08:54:38]

Yep, that makes sense. Looks like an overzealous variable initialization on my
side.

LGTM % comment.

https://codereview.chromium.org/2354053003/diff/1/chrome/browser/ui/webui/bro...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2354053003/diff/1/chrome/browser/ui/webui/bro...
chrome/browser/ui/webui/browsing_history_handler.cc:470: this,
&BrowsingHistoryHandler::WebHistoryTimeout);
WebHistoryTimeout() is kind of equivalent to WebHistoryQueryComplete() with
empty result, so it should also set |has_synced_results_| to false.

[tsergeant, 2016-09-22 00:19:59]

https://codereview.chromium.org/2354053003/diff/1/chrome/browser/ui/webui/bro...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2354053003/diff/1/chrome/browser/ui/webui/bro...
chrome/browser/ui/webui/browsing_history_handler.cc:470: this,
&BrowsingHistoryHandler::WebHistoryTimeout);
On 2016/09/21 08:54:38, msramek wrote:
> WebHistoryTimeout() is kind of equivalent to WebHistoryQueryComplete() with
> empty result, so it should also set |has_synced_results_| to false.

Good point, done.

[tsergeant, 2016-09-22 00:20:07]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-09-22 00:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2354053003/#ps20001
(title: "Timeout also resets value")

[commit-bot: I haz the power, 2016-09-22 00:20:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 01:00:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 01:06:03]

Description was changed from

==========
History: Fix flicker of sync notices when loading new data

The history page shows a notice when showing synced results from other
devices. This notice would frequently flicker when loading in new
results (eg, from a search), which was particularly noticable on the MD
History page, where this can cause toolbar elements to move around.

This fixes the issue by only resetting notice status back to false
when there is no web history service. In all other cases, we can
rely on the call to web history to reset the sync notices to their
correct values.

BUG=628555
==========

to

==========
History: Fix flicker of sync notices when loading new data

The history page shows a notice when showing synced results from other
devices. This notice would frequently flicker when loading in new
results (eg, from a search), which was particularly noticable on the MD
History page, where this can cause toolbar elements to move around.

This fixes the issue by only resetting notice status back to false
when there is no web history service. In all other cases, we can
rely on the call to web history to reset the sync notices to their
correct values.

BUG=628555

Committed: https://crrev.com/462304822ad58b7755e9de924c8cda4af093160e
Cr-Commit-Position: refs/heads/master@{#420220}
==========

[commit-bot: I haz the power, 2016-09-22 01:06:04]

Patchset 2 (id:??) landed as
https://crrev.com/462304822ad58b7755e9de924c8cda4af093160e
Cr-Commit-Position: refs/heads/master@{#420220}