Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2354053003: History: Fix flicker of sync notices when loading new data (Closed)
Patch Set: Timeout also resets value Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/browsing_history_handler.cc
diff --git a/chrome/browser/ui/webui/browsing_history_handler.cc b/chrome/browser/ui/webui/browsing_history_handler.cc
index dbc8eccae65de458d204bbf0e76f789f42f31651..9bb4a55c712ef70b68fe3ddb38d4573fd5ab3954 100644
--- a/chrome/browser/ui/webui/browsing_history_handler.cc
+++ b/chrome/browser/ui/webui/browsing_history_handler.cc
@@ -418,6 +418,7 @@ void BrowsingHistoryHandler::OnStateChanged() {
}
void BrowsingHistoryHandler::WebHistoryTimeout() {
+ has_synced_results_ = false;
// TODO(dubroy): Communicate the failure to the front end.
if (!query_task_tracker_.HasTrackedTasks())
ReturnResultsToFrontEnd();
@@ -438,8 +439,6 @@ void BrowsingHistoryHandler::QueryHistory(
query_results_.clear();
results_info_value_.Clear();
- has_synced_results_ = false;
- has_other_forms_of_browsing_history_ = false;
history::HistoryService* hs = HistoryServiceFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS);
@@ -481,6 +480,8 @@ void BrowsingHistoryHandler::QueryHistory(
} else {
// The notice could not have been shown, because there is no web history.
RecordMetricsForNoticeAboutOtherFormsOfBrowsingHistory(false);
+ has_synced_results_ = false;
+ has_other_forms_of_browsing_history_ = false;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698