Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2354023002: Fix caret invalidation in slimmingPaintInvalidation path (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix caret invalidation in slimmingPaintInvalidation path TEST=paint/invalidation/caret-color.html BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/0c24cf8e3e453ac71f0c0a17988a887550ae7d01 Cr-Commit-Position: refs/heads/master@{#419978}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/BlockPaintInvalidator.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Xianzhu
4 years, 3 months ago (2016-09-20 21:50:51 UTC) #9
chrishtr
lgtm
4 years, 3 months ago (2016-09-20 23:47:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354023002/20001
4 years, 3 months ago (2016-09-21 03:37:28 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 05:29:10 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 05:30:36 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c24cf8e3e453ac71f0c0a17988a887550ae7d01
Cr-Commit-Position: refs/heads/master@{#419978}

Powered by Google App Engine
This is Rietveld 408576698