Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2354023002: Fix caret invalidation in slimmingPaintInvalidation path (Closed)
Patch Set: - Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 357
358 bool isSelectionRoot() const; 358 bool isSelectionRoot() const;
359 359
360 public: 360 public:
361 bool hasCursorCaret() const; 361 bool hasCursorCaret() const;
362 bool hasDragCaret() const; 362 bool hasDragCaret() const;
363 bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); } 363 bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); }
364 364
365 protected: 365 protected:
366 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override; 366 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override;
367 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidatorContex t&) const override;
367 368
368 private: 369 private:
369 LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidt hToEndOfLine = nullptr) final; 370 LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidt hToEndOfLine = nullptr) final;
370 bool isInlineBoxWrapperActuallyChild() const; 371 bool isInlineBoxWrapperActuallyChild() const;
371 372
372 Position positionForBox(InlineBox*, bool start = true) const; 373 Position positionForBox(InlineBox*, bool start = true) const;
373 374
374 // End helper functions and structs used by layoutBlockChildren. 375 // End helper functions and structs used by layoutBlockChildren.
375 376
376 void removeFromGlobalMaps(); 377 void removeFromGlobalMaps();
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 // TODO(lunalu): Temporary in order to ensure compatibility with existing la yout test 430 // TODO(lunalu): Temporary in order to ensure compatibility with existing la yout test
430 // results. 431 // results.
431 virtual void adjustChildDebugRect(LayoutRect&) const {} 432 virtual void adjustChildDebugRect(LayoutRect&) const {}
432 }; 433 };
433 434
434 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 435 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
435 436
436 } // namespace blink 437 } // namespace blink
437 438
438 #endif // LayoutBlock_h 439 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698