Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2353953002: Disable flaky MigrationSingleClientTest tests. (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, lgcheng, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky MigrationSingleClientTest tests. These are reported as flaky. Though locally they fail every time? Disabling: - MigrationSingleClientTest.AllTypesAtOnce - MigrationSingleClientTest.AllTypesAtOnceTriggerNotification - MigrationSingleClientTest.AllTypesWithNigoriAtOnce - MigrationSingleClientTest.BookmarksPrefsBoth - MigrationSingleClientTest.BookmarksPrefsIndividually - MigrationSingleClientTest.NigoriOnly - MigrationSingleClientTest.PrefsNigoriBoth - MigrationSingleClientTest.PrefsOnlyModifyBookmark - MigrationSingleClientTest.PrefsOnlyModifyPref - MigrationSingleClientTest.PrefsOnlyTriggerNotification With this, *ALL* MigrationSingleClientTests that were not already disabled are disabled. This bug needs to be investigated and the tests re-enabled. BUG=648480 NOTRY=True TBR=lgcheng,stevenjb,pavely Committed: https://crrev.com/76ad59ea95d48f29f5b8658d467d6323789f1b51 Cr-Commit-Position: refs/heads/master@{#419757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/browser/sync/test/integration/migration_test.cc View 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353953002/1
4 years, 3 months ago (2016-09-20 14:49:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 14:53:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76ad59ea95d48f29f5b8658d467d6323789f1b51 Cr-Commit-Position: refs/heads/master@{#419757}
4 years, 3 months ago (2016-09-20 14:55:23 UTC) #5
ymalik
4 years, 3 months ago (2016-09-20 15:14:56 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2351903003/ by ymalik@chromium.org.

The reason for reverting is: No need to disable these tests as the flakyness was
fixed by https://codereview.chromium.org/2338213009.

Powered by Google App Engine
This is Rietveld 408576698