Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 23538007: Drop GetCurrentThreadId() and TerminateExecution(int) from the external API. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Drop GetCurrentThreadId() and TerminateExecution(int) from the external API. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -124 lines) Patch
M include/v8.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-09-06 11:24:32 UTC) #1
dcarney
lgtm
7 years, 3 months ago (2013-09-06 11:27:21 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-09-06 11:29:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698