Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2353783004: Revert of services/shell: Turn on sandboxing for mojo apps. (Closed)

Created:
2 years, 11 months ago by loyso (OOO)
Modified:
2 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of services/shell: Turn on sandboxing for mojo apps. (patchset #9 id:180001 of https://codereview.chromium.org/2338793003/ ) Reason for revert: Causes a timeout on mash_browser_tests. Original issue's description: > services/shell: Turn on sandboxing for mojo apps. > > Turn on sandbox for mojo apps by default. Apps that need to run > without a sandbox need to include 'shell:unsandboxed' in their > capabilities in manifest for mojo:shell. > > Update manifests for mojo:ui, mojo:font_service, mojo:file_system, > and mojo:leveldb services to include 'shell:unsandboxed'. > > BUG=645602, 646376 > > Committed: https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570 > Cr-Commit-Position: refs/heads/master@{#419891} TBR=rockot@chromium.org,ben@chromium.org,tsepez@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645602, 646376 Committed: https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823 Cr-Commit-Position: refs/heads/master@{#419928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M chrome/app/mash/mash_runner.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/filesystem/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M components/font_service/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M components/leveldb/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M services/shell/service_manager.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M services/ui/manifest.json View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
loyso (OOO)
Created Revert of services/shell: Turn on sandboxing for mojo apps.
2 years, 11 months ago (2016-09-21 01:06:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353783004/1
2 years, 11 months ago (2016-09-21 01:07:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 11 months ago (2016-09-21 01:08:25 UTC) #4
commit-bot: I haz the power
2 years, 11 months ago (2016-09-21 01:10:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823
Cr-Commit-Position: refs/heads/master@{#419928}

Powered by Google App Engine
This is Rietveld 408576698