Fix missing shadows for modal window

Fix missing shadows for modal window

When using a transparent visual the window manager does not draw any
shadow by default (ex: 'Compiz' WM). Note that this default behavior
is WM dependent.

So the solution is to not use a transparent visual for ui::MODAL_TYPE_NONE
(Window is not modal)

Keep trying to use a transparent visual for type TYPE_DRAG or non-modal
TYPE_WINDOW because of crbug.com/593256 and crbug.com/369209.

BUG=640170
R=sadrul@chromium.org

TEST=Go to chrome://help and hits 'report-issue.openFeedbackDialog' button

[Julien Isorce Samsung, 2016-09-19 22:33:10]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-09-19 22:33:37]

Hello Sadrul, please have a look. Thx.

[commit-bot: I haz the power, 2016-09-19 23:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:15:07]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-20 02:28:40]

This feels a bit weird. I have left a comment in the bug.

[Tom (Use chromium acct), 2016-09-20 05:32:34]

thomasanderson@google.com changed reviewers:
+ thomasanderson@chromium.org, thomasanderson@google.com

[Tom (Use chromium acct), 2016-09-20 05:32:34]

Maybe you've already tried this, but I think you should first look in
Widget::InitParmas::opacity and check if it is either OPAQUE_WINDOW or
TRANSLUCENT_WINDOW.  If it is either of those, you don't have to guess if it is
transparent or not.

If it's INFER_OPACITY, then I think you should only use transparent visuals for
windows that are TYPE_DRAG.  The comment in Widget::InitParams::WindowOpacity
suggests that TYPE_WINDOW should be opaque, and I can't think of any cases where
that would not be true.  If there are, PLMK.

[Julien Isorce Samsung, 2016-09-20 17:10:05]

On 2016/09/20 02:28:40, sadrul wrote:
> This feels a bit weird. I have left a comment in the bug.

After enabling the right "report an issue/feeback" window (I was using
--enable-md-feedback previously)
I can see that this CL does not fix the issue. Indeed that window is not modal.
It is created from ChromeNativeAppWindowViews::InitializeDefaultWindow and its
wm_role_name is "app".

[Julien Isorce Samsung, 2016-09-20 17:13:14]

On 2016/09/20 05:32:34, Tom Anderson wrote:
> Maybe you've already tried this, but I think you should first look in
> Widget::InitParmas::opacity and check if it is either OPAQUE_WINDOW or
> TRANSLUCENT_WINDOW.  If it is either of those, you don't have to guess if it
is
> transparent or not.
> 
> If it's INFER_OPACITY, then I think you should only use transparent visuals
for
> windows that are TYPE_DRAG.  The comment in Widget::InitParams::WindowOpacity
> suggests that TYPE_WINDOW should be opaque, and I can't think of any cases
where
> that would not be true.  If there are, PLMK.

Hi Tom, thx for the suggestion. Actually it did not want to rely on that opacity
param for symmetry with DesktopWindowTreeHostWin.

[Julien Isorce Samsung, 2016-09-20 17:25:36]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 17:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-09-20 17:26:51]

I uploaded Patch Set 2. Please have a look. Thx.
Note that I am on holidays, returning on 29th September.

[commit-bot: I haz the power, 2016-09-20 18:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:51:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julien Isorce Samsung, 2016-09-29 15:55:55]

On 2016/09/20 17:26:51, Julien Isorce wrote:
> I uploaded Patch Set 2. Please have a look. Thx.
> Note that I am on holidays, returning on 29th September.

The fix is in https://codereview.chromium.org/2347383002/ (especially see
https://codereview.chromium.org/2347383002/patch/280001/290047)

[Julien Isorce Samsung, 2016-09-29 15:56:10]

Description was changed from

==========
Fix missing shadows for modal window

When using a transparent visual the window manager does not draw any
shadow by default (ex: 'Compiz' WM). Note that this default behavior
is WM dependent.

So the solution is to not use a transparent visual for ui::MODAL_TYPE_NONE
(Window is not modal)

Keep trying to use a transparent visual for type TYPE_DRAG or non-modal
TYPE_WINDOW because of crbug.com/593256 and crbug.com/369209.

BUG=640170

R=sadrul@chromium.org

TEST=Go to chrome://help and hits 'report-issue.openFeedbackDialog' button
==========

to

==========
Fix missing shadows for modal window

When using a transparent visual the window manager does not draw any
shadow by default (ex: 'Compiz' WM). Note that this default behavior
is WM dependent.

So the solution is to not use a transparent visual for ui::MODAL_TYPE_NONE
(Window is not modal)

Keep trying to use a transparent visual for type TYPE_DRAG or non-modal
TYPE_WINDOW because of crbug.com/593256 and crbug.com/369209.

BUG=640170

R=sadrul@chromium.org

TEST=Go to chrome://help and hits 'report-issue.openFeedbackDialog' button
==========