Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Issue 2353783002: Fix missing shadows for modal window (Closed)
Patch Set: Really fix missing shadow for the feedback window Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
index 38a416bb19ca7db7b8690c143237c1cf8435b6c9..e188c22f8f4a092cfffba18fe94de92675696893 100644
--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
@@ -1359,9 +1359,13 @@ void DesktopWindowTreeHostX11::InitX11Window(
if (swa.override_redirect)
attribute_mask |= CWOverrideRedirect;
+ Widget* widget = native_widget_delegate_->AsWidget();
const bool enable_transparent_visuals =
params.type == Widget::InitParams::TYPE_DRAG ||
- params.type == Widget::InitParams::TYPE_WINDOW;
+ (params.type == Widget::InitParams::TYPE_WINDOW &&
+ params.wm_role_name == "browser") ||
+ (params.type == Widget::InitParams::TYPE_WINDOW && !widget->IsModal() &&
+ params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW);
Visual* visual = CopyFromParent;
int depth = CopyFromParent;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698