Issue 23537049: Merge 157801 "Fix lifetime handling of SVGPropertyTearOffs."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23537049: Merge 157801 "Fix lifetime handling of SVGPropertyTearOffs." (Closed)

Created:
7 years, 3 months ago by ojan

Modified:
7 years, 3 months ago

Reviewers:
ojan

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, marja+watch_chromium.org, eae+blinkwatch, abarth-chromium, haraken, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1599/

Visibility:
Public.

More Reviews

Description

Merge 157801 "Fix lifetime handling of SVGPropertyTearOffs." > Fix lifetime handling of SVGPropertyTearOffs. > > -Replace SVGStaticPropertyWithParentTearOff with SVGMatrixTearOff > since it's only used in that one place. This means we can get rid > of the templatizing and the method pointer. > -Change SVGPropertyTearOff to keep track of it's child tearoffs > and call detachWrapper on its child tearoffs when it's destroyed > or when it's wrapper is detached. > -Have SVGPropertyTearOff hold WeakPtrs to the child tearoffs > to avoid having a cycle. > > BUG=288771 > > Review URL: https://chromiumcodereview.appspot.com/23995018 TBR=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157842

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -73 lines)			Patch
A +	LayoutTests/svg/transforms/svg-matrix-tearoff-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/transforms/svg-matrix-tearoff-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
A +	Source/core/svg/properties/SVGMatrixTearOff.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	Source/core/svg/properties/SVGPropertyTearOff.h	View	3 chunks	+25 lines, -2 lines	0 comments	Download
D	Source/core/svg/properties/SVGStaticPropertyWithParentTearOff.h	View	1 chunk	+0 lines, -70 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r157842.

Expand Messages | Collapse Messages