Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23537049: Merge 157801 "Fix lifetime handling of SVGPropertyTearOffs." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1599/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 1508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1519 my $wrappedValue; 1519 my $wrappedValue;
1520 if (IsSVGTypeWithWritablePropertiesNeedingTearOff($attrType) and not def ined $attribute->extendedAttributes->{"Immutable"}) { 1520 if (IsSVGTypeWithWritablePropertiesNeedingTearOff($attrType) and not def ined $attribute->extendedAttributes->{"Immutable"}) {
1521 my $getter = $expression; 1521 my $getter = $expression;
1522 $getter =~ s/imp->//; 1522 $getter =~ s/imp->//;
1523 $getter =~ s/\(\)//; 1523 $getter =~ s/\(\)//;
1524 1524
1525 my $updateMethod = "&${implClassName}::update" . FirstLetterToUpperC ase($getter); 1525 my $updateMethod = "&${implClassName}::update" . FirstLetterToUpperC ase($getter);
1526 1526
1527 my $selfIsTearOffType = IsSVGTypeNeedingTearOff($interfaceName); 1527 my $selfIsTearOffType = IsSVGTypeNeedingTearOff($interfaceName);
1528 if ($selfIsTearOffType) { 1528 if ($selfIsTearOffType) {
1529 AddToImplIncludes("core/svg/properties/SVGStaticPropertyWithPare ntTearOff.h"); 1529 AddToImplIncludes("core/svg/properties/SVGMatrixTearOff.h");
1530 $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyWithParen tTearOff<$implClassName, /; 1530 # FIXME: Don't create a new one everytime we access the matrix p roperty. This means, e.g, === won't work.
1531 1531 $wrappedValue = "WTF::getPtr(SVGMatrixTearOff::create(wrapper, $ expression))";
1532 $wrappedValue = "WTF::getPtr(${tearOffType}::create(wrapper, $ex pression, $updateMethod))";
1533 } else { 1532 } else {
1534 AddToImplIncludes("core/svg/properties/SVGStaticPropertyTearOff. h"); 1533 AddToImplIncludes("core/svg/properties/SVGStaticPropertyTearOff. h");
1535 $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$ implClassName, /; 1534 $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$ implClassName, /;
1536 1535
1537 $wrappedValue = "WTF::getPtr(${tearOffType}::create(imp, $expres sion, $updateMethod))"; 1536 $wrappedValue = "WTF::getPtr(${tearOffType}::create(imp, $expres sion, $updateMethod))";
1538 } 1537 }
1539 } elsif ($tearOffType =~ /SVGStaticListPropertyTearOff/) { 1538 } elsif ($tearOffType =~ /SVGStaticListPropertyTearOff/) {
1540 $wrappedValue = "WTF::getPtr(${tearOffType}::create(imp, $expres sion))"; 1539 $wrappedValue = "WTF::getPtr(${tearOffType}::create(imp, $expres sion))";
1541 } elsif ($tearOffType =~ /SVG(Point|PathSeg)List/) { 1540 } elsif ($tearOffType =~ /SVG(Point|PathSeg)List/) {
1542 $wrappedValue = "WTF::getPtr($expression)"; 1541 $wrappedValue = "WTF::getPtr($expression)";
(...skipping 4465 matching lines...) Expand 10 before | Expand all | Expand 10 after
6008 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 6007 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
6009 $found = 1; 6008 $found = 1;
6010 } 6009 }
6011 return 1 if $found; 6010 return 1 if $found;
6012 }, 0); 6011 }, 0);
6013 6012
6014 return $found; 6013 return $found;
6015 } 6014 }
6016 6015
6017 1; 6016 1;
OLDNEW
« no previous file with comments | « LayoutTests/svg/transforms/svg-matrix-tearoff-crash-expected.txt ('k') | Source/core/svg/properties/SVGMatrixTearOff.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698