Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 1 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index 28943430d873e5126cd22ab7b8c597e752231822..45ddf05d4060dc2cdb5983cdacefdeb171e3a54c 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -295,12 +295,14 @@ class TabSpecificContentSettings
virtual void AppCacheAccessed(const GURL& manifest_url,
bool blocked_by_policy) OVERRIDE;
- // If user clicks on 'save password' this will have the password saved upon
- // the next navigation.
+ // Called when the user clicks 'save password' button. Instructs
+ // |form_to_save| to save the password when the next navigation occurs or
+ // when the tab is closed.
bool PasswordAccepted();
Peter Kasting 2013/09/10 23:04:41 These two functions should also be replaced by a s
npentrel 2013/09/11 09:10:42 Done.
- // If user clicks on 'never save password for this site' this have the
- // password blacklisted upon the next navigation.
+ // Called when the user clicks 'never for this site' button. Instructs
+ // |form_to_save| to blacklist the password when the next navigation occurs
+ // or when the tab is closed.
bool PasswordFormBlacklisted();
// Message handlers. Public for testing.
@@ -342,9 +344,9 @@ class TabSpecificContentSettings
const MediaStreamDevicesController::MediaStreamTypePermissionMap&
request_permissions);
- // This method is called to pass the |form_to_save| on a successful password
- // submission. It also updates the status of the save password content
- // setting.
+ // Called when a password form is submitted. |form_to_save| is the submitted
+ // form. This form can save or blacklist the login credentials via
+ // PasswordAccepted() and PasswordFormBlacklisted respectively.
void OnPasswordSubmitted(PasswordFormManager* form_to_save);
// There methods are called to update the status about MIDI access.

Powered by Google App Engine
This is Rietveld 408576698