chrome/browser/content_settings/tab_specific_content_settings.cc - Issue 23537029: Save password functionality added to the save password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.cc

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review 1 Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/tab_specific_content_settings.h ('K') | « chrome/browser/content_settings/tab_specific_content_settings.h ('k') | chrome/browser/password_manager/password_form_manager.h » ('j') | chrome/browser/password_manager/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/tab_specific_content_settings.cc

diff --git a/chrome/browser/content_settings/tab_specific_content_settings.cc b/chrome/browser/content_settings/tab_specific_content_settings.cc

index 2b7550701d88ce0957004de8f3a042110b3da80d..fd171dc330196f82c878d5296e88c22f9b4aaf73 100644

--- a/chrome/browser/content_settings/tab_specific_content_settings.cc

+++ b/chrome/browser/content_settings/tab_specific_content_settings.cc

@@ -101,13 +101,13 @@ TabSpecificContentSettings::~TabSpecificContentSettings() {

bool TabSpecificContentSettings::PasswordAccepted() {

DCHECK(form_to_save_.get());

- form_to_save_->SavePassword();

+ form_to_save_->SetPasswordAction(PasswordFormManager::SAVE);

return true;

}

bool TabSpecificContentSettings::PasswordFormBlacklisted() {

DCHECK(form_to_save_.get());

- form_to_save_->BlacklistPassword();

+ form_to_save_->SetPasswordAction(PasswordFormManager::BLACKLIST);

return true;

}