base/message_loop/message_loop.cc - Issue 23537016: gtk: Some code cleanup for the message-pump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_loop.cc

Issue 23537016: gtk: Some code cleanup for the message-pump. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_loop.cc

diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc

index 701594a122c7562b675680188a24949f99a46e6f..ced44a14d8a8308cf7a54ffdeaf1524057244490 100644

--- a/base/message_loop/message_loop.cc

+++ b/base/message_loop/message_loop.cc

@@ -425,7 +425,7 @@ void MessageLoop::RunInternal() {

StartHistogrammer();

-#if !defined(OS_MACOSX) && !defined(OS_ANDROID)

+#if !defined(OS_MACOSX) && !defined(OS_ANDROID) && !defined(USE_GTK_MESSAGE_PUMP)

piman 2013/09/05 17:37:47 I'm not sure I understand why it's ok not to run w

sadrul 2013/09/05 17:53:12 Chrome currently does not use any Dispatcher in li

if (run_loop_->dispatcher_ && type() == TYPE_UI) {

static_cast<MessagePumpForUI*>(pump_.get())->

RunWithDispatcher(this, run_loop_->dispatcher_);