gtk: Some code cleanup for the message-pump.

base/message_loop/message_loop.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 407 matching lines @@
   }
   return;
 }
 #endif
 
 void MessageLoop::RunInternal() {
   DCHECK_EQ(this, current());
 
   StartHistogrammer();
 
-#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
+#if !defined(OS_MACOSX) && !defined(OS_ANDROID) && !defined(USE_GTK_MESSAGE_PUMP)

[piman, 2013/09/05 17:37:47]

I'm not sure I understand why it's ok not to run with a dispatcher any more. Are
we never using one?

[sadrul, 2013/09/05 17:53:12]

Chrome currently does not use any Dispatcher in linux-gtk, no (this CL also
removes the MessagePumpDispatcher defined in message_pump_gtk.h).

A different option would be to have a new define, e.g.
MESSAGE_LOOP_USES_DISPATCHER in message_loop.h, and use that in the code to make
this more readable/obvious.

   if (run_loop_->dispatcher_ && type() == TYPE_UI) {
     static_cast<MessagePumpForUI*>(pump_.get())->
         RunWithDispatcher(this, run_loop_->dispatcher_);
     return;
   }
 #endif
 
   pump_->Run(this);
 }
 
@@ skipping 310 matching lines @@
       fd,
       persistent,
       mode,
       controller,
       delegate);
 }
 
 #endif
 
 }  // namespace base