Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2353683003: [NaCl SDK] Re-enable 32-bit sel_ldr build for mac (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, bradnelson, sbc
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Re-enable 32-bit sel_ldr build for mac The lack of sel_ldr_x86_32 is causing the webports tree to be red for all mac builders. Re-enabling seems more trivial and updating expectations in webports. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/3b0de86e99418c0e59b1532f197ef127a456e3e2 Cr-Commit-Position: refs/heads/master@{#419619}

Patch Set 1 #

Patch Set 2 : Revert "Drop gn mac + linux 32-bit builds in nacl sdk." #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 3 4 5 3 chunks +8 lines, -12 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
sbc
4 years, 3 months ago (2016-09-19 22:59:48 UTC) #5
bradnelson
lgtm
4 years, 3 months ago (2016-09-19 23:26:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353683003/100001
4 years, 3 months ago (2016-09-19 23:27:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262476)
4 years, 3 months ago (2016-09-19 23:36:48 UTC) #11
sbc
+dpranke for BUILD.gn
4 years, 3 months ago (2016-09-19 23:39:52 UTC) #13
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-19 23:42:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353683003/100001
4 years, 3 months ago (2016-09-19 23:43:43 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-20 01:11:44 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:14:22 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3b0de86e99418c0e59b1532f197ef127a456e3e2
Cr-Commit-Position: refs/heads/master@{#419619}

Powered by Google App Engine
This is Rietveld 408576698