Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: native_client_sdk/src/build_tools/test_sdk.py

Issue 2353683003: [NaCl SDK] Re-enable 32-bit sel_ldr build for mac (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/build_tools/sdk_files.list ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/test_sdk.py
diff --git a/native_client_sdk/src/build_tools/test_sdk.py b/native_client_sdk/src/build_tools/test_sdk.py
index a2994fa8b6fd9bc5b9191448b71edc98960559f7..3a3c8ffa7e0026e73888e422969cf3670b9aded0 100755
--- a/native_client_sdk/src/build_tools/test_sdk.py
+++ b/native_client_sdk/src/build_tools/test_sdk.py
@@ -101,12 +101,11 @@ def StepRunSelLdrTests(pepperdir, sanitizer):
args=args + ['run'])
if getos.GetPlatform() == 'win':
- # On win32 we only support running on the system
- # arch
+ # On win32 we only support running on the system arch
archs = (getos.GetSystemArch('win'),)
elif getos.GetPlatform() == 'mac':
- # We only ship 64-bit version of sel_ldr on mac.
- archs = ('x86_64',)
+ # On mac we can run both 32 and 64-bit
+ archs = ('x86_64', 'x86_32')
else:
# On linux we can run both 32 and 64-bit, and arm (via qemu)
archs = ('x86_64', 'x86_32', 'arm')
« no previous file with comments | « native_client_sdk/src/build_tools/sdk_files.list ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698