Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2353663004: Fix invalid suggestion window position on ChromeOS and Windwos. (Closed)

Created:
4 years, 3 months ago by Seigo Nonaka
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix invalid suggestion window position on ChromeOS and Windwos. This is regression from http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b The show_ime_if_needed is one shot message so we can't use it as a trigger of monitoring composition bounding box, since we need to keep monitoring during the text input session is active. BUG=640012 Review-Url: https://codereview.chromium.org/2330423002 Cr-Commit-Position: refs/heads/master@{#418491} (cherry picked from commit 14f15f11744445a7adb34030719afeb41a9432d0) Committed: https://chromium.googlesource.com/chromium/src/+/26e487a3d8add5a2c4e969565ac7c488c959d906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Seigo Nonaka
4 years, 3 months ago (2016-09-20 01:30:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26e487a3d8add5a2c4e969565ac7c488c959d906.

Powered by Google App Engine
This is Rietveld 408576698