Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2330423002: Fix invalid suggestion window position on ChromeOS and Windwos. (Closed)

Created:
4 years, 3 months ago by Seigo Nonaka
Modified:
4 years, 3 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix invalid suggestion window position on ChromeOS and Windwos. This is regression from http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b The show_ime_if_needed is one shot message so we can't use it as a trigger of monitoring composition bounding box, since we need to keep monitoring during the text input session is active. BUG=640012 Committed: https://crrev.com/14f15f11744445a7adb34030719afeb41a9432d0 Cr-Commit-Position: refs/heads/master@{#418491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Seigo Nonaka
Hi Alex, could you kindly take a look? Thank you.
4 years, 3 months ago (2016-09-13 16:34:03 UTC) #7
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-13 18:17:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330423002/1
4 years, 3 months ago (2016-09-14 05:32:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 05:36:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 05:38:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f15f11744445a7adb34030719afeb41a9432d0
Cr-Commit-Position: refs/heads/master@{#418491}

Powered by Google App Engine
This is Rietveld 408576698