Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: device/generic_sensor/public/cpp/platform_sensor_configuration.cc

Issue 2353493002: [Sensors] Allow Sensor API only on secure top-level browsing contexts and add frequency checks (Closed)
Patch Set: Comments from Tim Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/public/cpp/platform_sensor_configuration.cc
diff --git a/device/generic_sensor/public/cpp/platform_sensor_configuration.cc b/device/generic_sensor/public/cpp/platform_sensor_configuration.cc
index 4061ad0681193d26fd7eebc28d8ec7f445b7fdc8..44b26b32b3902fda9cf9807e145e37c226c34238 100644
--- a/device/generic_sensor/public/cpp/platform_sensor_configuration.cc
+++ b/device/generic_sensor/public/cpp/platform_sensor_configuration.cc
@@ -4,16 +4,25 @@
#include "device/generic_sensor/public/cpp/platform_sensor_configuration.h"
+#include "device/generic_sensor/public/interfaces/sensor.mojom.h"
+
namespace device {
PlatformSensorConfiguration::PlatformSensorConfiguration(double frequency)
: frequency_(frequency) {
- DCHECK(frequency_ <= kMaxAllowedFrequency && frequency_ > 0.0);
+ DCHECK(frequency_ <= mojom::SensorConfiguration::kMaxAllowedFrequency &&
+ frequency_ > 0.0);
}
PlatformSensorConfiguration::PlatformSensorConfiguration() = default;
PlatformSensorConfiguration::~PlatformSensorConfiguration() = default;
+void PlatformSensorConfiguration::set_frequency(double frequency) {
+ DCHECK(frequency_ <= mojom::SensorConfiguration::kMaxAllowedFrequency &&
+ frequency_ > 0.0);
+ frequency_ = frequency;
+}
+
bool PlatformSensorConfiguration::operator==(
const PlatformSensorConfiguration& other) const {
return frequency_ == other.frequency();

Powered by Google App Engine
This is Rietveld 408576698