Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2353473003: Revert of Prevent redundant DoWorks due to canceled delayed tasks (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prevent redundant DoWorks due to canceled delayed tasks (patchset #6 id:100001 of https://codereview.chromium.org/2320403003/ ) Reason for revert: Suspect that this CL caused breakage in Gmail and Hangouts per http://crbug.com/647484 . Original issue's description: > Prevent redundant DoWorks due to canceled delayed tasks > > To achieve this we make a few changes: > > 1. We only register the next wakeup with the TimeDomain, rather than all > of them. > 2. MoveReadyDelayedTasksToDelayedWorkQueue now registers the next > wakeup (if any). Since it removes all canceled delayed tasks from the > front of the priority queue this has the effect of not scheduling > wakeups for cancelled tasks. > 3. Tweaking the TaskQueueManager level delayed DoWork de-duplication > logic to only post a delayed DoWork if the task is meant to run before > any previously registered delayed DoWorks. > > BUG=638542, 605718 > > Committed: https://crrev.com/929cbb9f92b5570867c3842c80778243db81a013 > Cr-Commit-Position: refs/heads/master@{#418556} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638542, 605718 Committed: https://crrev.com/04e1e5cab53931ea11d58a578a237d6a5762a054 Cr-Commit-Position: refs/heads/master@{#419542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -226 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 6 chunks +14 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 2 chunks +0 lines, -165 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 2 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Prevent redundant DoWorks due to canceled delayed tasks
4 years, 3 months ago (2016-09-19 18:20:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353473003/1
4 years, 3 months ago (2016-09-19 18:20:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 20:08:08 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04e1e5cab53931ea11d58a578a237d6a5762a054
Cr-Commit-Position: refs/heads/master@{#419542}

Powered by Google App Engine
This is Rietveld 408576698