third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc - Issue 2353473003: Revert of Prevent redundant DoWorks due to canceled delayed tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2353473003: Revert of Prevent redundant DoWorks due to canceled delayed tasks (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

index bcc4f868aac5fbc1a99520620306b20366349773..db351c79c3fe52a81049d8c2679f2e014581a695 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

@@ -190,14 +190,10 @@

return;

}

- // Only request the wake up if, either there are no wake ups scheduled, or if

- // its sooner than any previously requested wake up.

+ // De-duplicate DoWork posts.

base::TimeTicks run_time = now + delay;

- if (!main_thread_pending_wakeups_.empty() &&

- *main_thread_pending_wakeups_.begin() <= run_time) {

+ if (!main_thread_pending_wakeups_.insert(run_time).second)

return;

- }

- main_thread_pending_wakeups_.insert(run_time);

delegate_->PostDelayedTask(

from_here, base::Bind(&TaskQueueManager::DoWork,

weak_factory_.GetWeakPtr(), run_time, true),