Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2353453002: ui: Remove SurfaceTexture GpuMemoryBuffer type. (Closed)

Created:
4 years, 3 months ago by reveman
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Remove SurfaceTexture GpuMemoryBuffer type. This is not currently used and there are no plans to enable it. Remove it for now to keep the code simple. We can always add it back later if it turns out useful. BUG= TEST= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c0329013d5cacd4c6c135e9d130a66ac3e25db4a Cr-Commit-Position: refs/heads/master@{#420260}

Patch Set 1 #

Patch Set 2 : ui: Remove SurfaceTexture GpuMemoryBuffer type. #

Patch Set 3 : ui: Remove SurfaceTexture GpuMemoryBuffer type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -462 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/ipc/client/gpu_channel_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_surface_texture.h View 1 chunk +0 lines, -62 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_surface_texture.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_surface_texture_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M gpu/ipc/common/gpu_memory_buffer_support.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.h View 1 chunk +0 lines, -65 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/mojo/buffer_types.mojom View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/mojo/buffer_types_traits.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 60 (35 generated)
reveman
4 years, 3 months ago (2016-09-18 22:23:29 UTC) #15
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-19 14:47:18 UTC) #16
DaleCurtis
What were the reasons this went unused? We have libvpx decoding in Chrome now, so ...
4 years, 3 months ago (2016-09-19 18:43:00 UTC) #18
aelias_OOO_until_Jul13
It hasn't provided any performance improvement over a more normal kind of buffer, nor can ...
4 years, 3 months ago (2016-09-19 19:08:28 UTC) #19
DaleCurtis
Ah, yeah each one is a whole SurfaceTexture that's unfortunate.
4 years, 3 months ago (2016-09-19 19:13:03 UTC) #21
piman
LGTM, thanks for the cleanup!
4 years, 3 months ago (2016-09-19 20:37:44 UTC) #22
reveman
On 2016/09/19 at 20:37:44, piman wrote: > LGTM, thanks for the cleanup! Thanks for the ...
4 years, 3 months ago (2016-09-19 20:51:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-19 20:52:30 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262325)
4 years, 3 months ago (2016-09-19 21:02:46 UTC) #27
reveman
+rsesek for ui/gfx/mojo (security)
4 years, 3 months ago (2016-09-19 21:31:49 UTC) #29
Robert Sesek
lgtm
4 years, 3 months ago (2016-09-19 22:27:07 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-19 22:42:58 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262442)
4 years, 3 months ago (2016-09-19 22:52:35 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-20 06:57:53 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262710)
4 years, 3 months ago (2016-09-20 07:06:02 UTC) #38
reveman
+danakj for ui/gfx/mojo/buffer_types_traits.h fyi, I'll follow up with a patch that adjusts the ui/gfx/OWNER file ...
4 years, 3 months ago (2016-09-20 07:58:12 UTC) #40
reveman
+asvitkine for ui/gfx/
4 years, 3 months ago (2016-09-21 12:01:21 UTC) #42
Alexei Svitkine (slow)
gfx lgtm rubberstamp
4 years, 3 months ago (2016-09-21 15:32:19 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-21 15:49:02 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-21 17:50:27 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-21 20:09:41 UTC) #53
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/3892)
4 years, 3 months ago (2016-09-21 22:53:34 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353453002/40001
4 years, 3 months ago (2016-09-22 03:11:39 UTC) #57
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 04:05:08 UTC) #58
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 04:06:15 UTC) #60
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c0329013d5cacd4c6c135e9d130a66ac3e25db4a
Cr-Commit-Position: refs/heads/master@{#420260}

Powered by Google App Engine
This is Rietveld 408576698