Reland of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

Reland of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

Reverted in
https://codereview.chromium.org/2349253002

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)

BUG=633136
Committed: https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246
Cr-Commit-Position: refs/heads/master@{#421191}

[Tomasz Moniuszko, 2016-09-21 13:37:23]

tmoniuszko@opera.com changed reviewers:
+ chongz@chromium.org, pkasting@chromium.org, sadrul@chromium.org,
samuong@chromium.org, wez@chromium.org

[samuong, 2016-09-21 14:17:54]

lgtm for chrome/test/chromedriver

[Wez, 2016-09-21 16:28:19]

LGTM w/ nit.

https://codereview.chromium.org/2353333002/diff/20001/ui/events/test/keyboard...
File ui/events/test/keyboard_layout_mac.cc (right):

https://codereview.chromium.org/2353333002/diff/20001/ui/events/test/keyboard...
ui/events/test/keyboard_layout_mac.cc:34: base::scoped_policy::RETAIN);
nit: Woah, weird; it might be easier-to-read to use the ScopedCFTypeRef here
rather than the PlatformKeyboardLayout typedef.

[Peter Kasting, 2016-09-21 17:35:54]

RS LGTM

[sadrul, 2016-09-22 01:36:39]

stamp lgtm (with wez@'s comment addressed)

[Tomasz Moniuszko, 2016-09-23 13:00:48]

https://codereview.chromium.org/2353333002/diff/20001/ui/events/test/keyboard...
File ui/events/test/keyboard_layout_mac.cc (right):

https://codereview.chromium.org/2353333002/diff/20001/ui/events/test/keyboard...
ui/events/test/keyboard_layout_mac.cc:34: base::scoped_policy::RETAIN);
On 2016/09/21 16:28:19, Wez wrote:
> nit: Woah, weird; it might be easier-to-read to use the ScopedCFTypeRef here
> rather than the PlatformKeyboardLayout typedef.

Done.

[Tomasz Moniuszko, 2016-09-23 13:00:54]

The CQ bit was checked by tmoniuszko@opera.com

[Tomasz Moniuszko, 2016-09-23 13:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
samuong@chromium.org, pkasting@chromium.org, sadrul@chromium.org,
wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2353333002/#ps40001
(title: "Use ScopedCFTypeRef instead of PlatformKeyboardLayout")

[commit-bot: I haz the power, 2016-09-23 13:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 13:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 13:30:49]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Tomasz Moniuszko, 2016-09-27 12:31:04]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2016-09-27 12:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:35:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 13:37:22]

Description was changed from

==========
Reland of Force U.S. English keyboard layout for
TextfieldTest.KeysWithModifiersTest

Reverted in
https://codereview.chromium.org/2349253002

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...

BUG=633136
==========

to

==========
Reland of Force U.S. English keyboard layout for
TextfieldTest.KeysWithModifiersTest

Reverted in
https://codereview.chromium.org/2349253002

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...

BUG=633136

Committed: https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246
Cr-Commit-Position: refs/heads/master@{#421191}
==========

[commit-bot: I haz the power, 2016-09-27 13:37:24]

Patchset 3 (id:??) landed as
https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246
Cr-Commit-Position: refs/heads/master@{#421191}